contentsync / SketchContentSync

Sync sketch files with google docs.
275 stars 17 forks source link

Ability to allow/disallow certain text fields #65

Closed markgrahamdunn closed 6 years ago

markgrahamdunn commented 7 years ago

Would there be a possibility in a future release to exclude certain text fields using a key e.g ~aTextfield... or turn it around, only text fields with a certain char / key will be pushed to google sheets?

dbrody commented 7 years ago

Yes, we can look into creating some option to enable/disable syncing on a layer. We'd like to avoid special naming on the layer since it may interfere with other plugins / conventions. Any ideas would be welcomed and we will look into options as well. Thanks for the comment!

markgrahamdunn commented 7 years ago

hi @dbrody thanks for your prompt reply. i would consider using a ∞ or ~ prefix to omit sending values of certain textfields. Would love to have this working on Artboard and Page level.

a.t.m my Symbol page gets automatically uploaded to google sheets while i would prefer this wouldn't happen.

dbrody commented 7 years ago

Our initial version of this takes a slightly different approach. We'd love to hear your thoughts.

We are thinking about it as built into the Sketch context menu instead of making it based on layer name. So if you right click on the page or any selection of layers, you have the option to enable/disabled syncing on it.

At the page level: screen shot 2017-09-20 at 7 53 07 am

For selected layers: screen shot 2017-09-20 at 7 53 29 am

The sidebar will gray out the push/pull if all selected layers or if the current page is disabled. This is a helpful hint to know if it is enabled or disabled: screen shot 2017-09-20 at 8 13 17 am

The menu will also only make the options that are currently applicable enabled: screen shot 2017-09-20 at 8 13 53 am

What do you think?

dbrody commented 7 years ago

@markgrahamdunn -

For now, as a work around, you can utilize the "Selective Sync" feature where if you have layers selected, only those layers will be synchronized.

So if you were to do a Cmd + A and select all the layers of a page and sync, only that page will be synced.

markgrahamdunn commented 7 years ago

Hi @dbrody,

my apologies for the late reply.. Work load tends to creep up in life.

I like your suggested proposal but would this contextual functionality also be available as an option if a user control + click's on a Page name (under Pages) or Artboard name instead of relying on a canvas interaction (page level)? Also would you intend to have a visual cue in the Layer lists & Page list or leave it like it currently is.? Example an icon next to a page name, artboard name, layer name that hints if an Page, Artboard or Layer has Sync enabled?

My impression is having a single greyed-out icon in the Sidebar as a hint gives the impression that the functionality is not working (disabled) and also doesn't give valid feedback on a granular level.

markgrahamdunn commented 7 years ago

regarding the "Selective Sync" feature: i did use this in a R&D test phase however in our current design workflow this feature isn't used that much. We tend to have x amount of artboards with dummy copy that we want to push to google sheets in one sweep instead of manualy selection each layer on x Artboard and pushing that to g sheets.

dbrody commented 6 years ago

@markgrahamdunn - Thanks for the great feedback. We're excited to prepare for launch this feature with even better Sketch integration than before. :) Check it out...

Our initial approach is a simple strikethrough on the layer list when a layer is disabled for sync. If this proves to be too much of an interference in common usage we will eventually migrate it to some other symbolism such as an image or something. Any ideas would be welcome!

Enabling / Disabling an entire Page:

screen shot 2018-01-06 at 10 40 39 am screen shot 2018-01-06 at 10 40 50 am screen shot 2018-01-06 at 10 41 01 am

Enabling / Disabling Layers:

screen shot 2018-01-06 at 10 41 09 am screen shot 2018-01-06 at 10 45 30 am screen shot 2018-01-06 at 10 46 51 am

Toggling Direct on the Draw View

screen shot 2018-01-06 at 10 50 23 am

This will be rolling out soon in our next release in the coming week.

dbrody commented 6 years ago

@markgrahamdunn - This feature is going live with release 3.1.1 (#67)

dbrody commented 6 years ago

Released with 3.1.1