search

contiamo / operational-ui

Building blocks for effective operational interfaces
https://operational-ui.netlify.com
MIT License
259 stars 46 forks source link

**Fix:** z-index for select #1307

Closed stereobooster closed 4 years ago

stereobooster commented 4 years ago

Summary

Do not merge

See Components/DropdownButton

Before:

Screenshot 2020-03-06 at 15 08 26 Screenshot 2020-03-06 at 15 08 34

After:

Screenshot 2020-03-06 at 15 10 28 Screenshot 2020-03-06 at 15 10 34

Related issue

https://github.com/contiamo/operational-ui/pull/1305

To be tested

Me

Tester 1

Tester 2

mpotomin commented 4 years ago

@stereobooster I honestly feel very frustrated about the need of the 3rd PR in a row to fix the same thing. It's a lot of back-and-forth of reviewing and testing, resulted in wasted time and energy. Could you please confirm that you applied this PR to contiamo-ui locally and tested it in all the use use-cases?

mpotomin commented 4 years ago

Just a random idea. Would it make sense to provide z-index for the Select's drop-down from the outside, as a prop? So we could handle the edge cases like "Select within the Modal", "Select above some 3rd-party component" in-place, as an escape-hatch?