contiamo / operational-ui

Building blocks for effective operational interfaces
https://operational-ui.netlify.com
MIT License
259 stars 46 forks source link

**Fix:** Remove hasIconOffset, add <Example/> instead of <Example> #1344

Closed rimildeyjsr closed 3 years ago

rimildeyjsr commented 4 years ago

Remove hasIconOffset property to fix the extra padding for trees with no children, removes misalignment Use instead of to fix the warning in the code example

Fixes #1321

Summary

The last level of a nested tree was being misaligned with the previous level.

The cause was the hasIconOffset being set true for when you have an icon or a tag along with a tree that has no children. It was adding some extra padding using the formula paddingLeft + theme.space.element * level + (hasIconOffset ? theme.space.element : 0)}px;

On removing the hasIconOffset, the last levels get aligned with appropriate padding. I am removing this property altogether because any nested tree with no children was getting misaligned, and the property did not provide any other functionality.

Also, added arrows to the style of the freeze tree, as suggested in the issue

Related issue

Fixes #1321

To be tested

Me

Tester 1

Tester 2

mpotomin commented 4 years ago

Hi @rimildeyjsr! Looks like there is an issue with the columns still: columns are children of tables, but there is no indentation showing that (columns should be shown one level deeper under tables)

Screenshot 2020-08-12 at 09 03 41 Screenshot 2020-08-12 at 09 03 36
rimildeyjsr commented 4 years ago

@mpotomin - Ah had not taken this into account, will fix this as well!