search

contiamo / restful-react

A consistent, declarative way of interacting with RESTful backends, featuring code-generation from Swagger and OpenAPI specs 🔥
MIT License
1.87k stars 109 forks source link

Move openapi validator to speccy #139

Open fabien0102 opened 5 years ago

fabien0102 commented 5 years ago

Is your feature request related to a problem? Please describe.

The ibm validator is nice, but way to strict… no un-usuable in practice (for example type: uuid is an error), let's move to speccy from our old friends -> wework!

https://github.com/wework/speccy

Describe the solution you'd like We need to way to enable/disable the validation and specify some custom rules from restful-react generate options.

Describe alternatives you've considered https://github.com/IBM/openapi-validator already in place, but sadly always disabled because it's too strict…

Additional context The main idea to have a validator/linter part of our tool is to provide a better message when specs are not valid. Restful-react assume that the spec is perfectly valid for now, so it can break with a non helping message… (at least it can be better)

Also, our backend team already use speccy as validator in CI 😉

TejasQ commented 4 years ago

100% support this.

marckassay commented 3 years ago

Any thoughts on upgrading openapi-validator from 0.16.0 to 0.46.4?

fabien0102 commented 3 years ago

Any thoughts on upgrading openapi-validator from 0.16.0 to 0.46.4?

You can! Just open a PR and I will review it with pleasure 😁

marckassay commented 3 years ago

And so can you. But why would or wouldn't you?

fabien0102 commented 3 years ago

I can do it, I was just in vacation last week, so not in front of a computer 😉

fabien0102 commented 3 years ago

Any thoughts on upgrading openapi-validator from 0.16.0 to 0.46.4?

Done, should be on 15.9.0 release 😀

marckassay commented 3 years ago

@fabien0102 Oh, thanks! I appreciate your work here on this project.