search

contiamo / restful-react

A consistent, declarative way of interacting with RESTful backends, featuring code-generation from Swagger and OpenAPI specs 🔥
MIT License
1.87k stars 109 forks source link

React Native support (issue with React peer dependency) #181

Closed owinter86 closed 4 years ago

owinter86 commented 4 years ago

Describe the bug This currently does not work with new React Native projects (non expo) due to RN targeting a specific React Version (currently 16.9.0), so due to the react peer dependency it will install react@^16.8.4 and therefore cause the error shown below.

I can confirm there are no issues if we remove react as a peer dependency, which will ensure when using with React native that two versions of react will not be installed. But unsure if this is a satisfactory resolution.

To Reproduce Steps to reproduce the behavior:

  1. init new react native project (without expo)
  2. install react restful
  3. try and use any hook

Expected behavior Should support the React Native Projects

Screenshots

Screen Shot 2019-11-19 at 11 49 52
South-Paw commented 4 years ago

@TejasQ Looks like this issue can be closed as well as PR has been merged.

fabien0102 commented 4 years ago

Seams to be fixed, please tell me if not 😉