continue-revolution / sd-webui-animatediff

AnimateDiff for AUTOMATIC1111 Stable Diffusion WebUI
Other
3.11k stars 258 forks source link

[Bug]: 2.0 is broken on v2v and I have double LCM causing all normal gens to be washed out in master. #413

Closed Ph0rk0z closed 8 months ago

Ph0rk0z commented 9 months ago

Is there an existing issue for this?

Have you read FAQ on README?

What happened?

I have been pulling on automatic1111 dev and one day saw 2 LCM samplers. Confused, I found that the PRs for LCM were merged into A1111 and saw you also modified the 2.0 branch.

I go to install the 2.0 branch and there are errors, in v2v it wasn't fixed when your removed the controlnet hacks. Now I have the issue where I get washed out gif/video on master without LCM lora and errors in the console and inability to get a generated video on 2.0. I don't even use v2v.

Steps to reproduce the problem

use latest, make a gif

What should have happened?

normal behavior

Commit where the problem happens

webui: git extension: 2.0 https://github.com/continue-revolution/sd-webui-animatediff/commit/1e57dda70d79eaf56350e93559c4379c7b64822f

What browsers do you use to access the UI ?

No response

Command Line Arguments

no ffs

Console logs

as described

Additional information

No response

continue-revolution commented 9 months ago

You are not supposed to use 2.0 for now and I’ve not finished working on it. The update for 2.0 is non-trivial - you need A1111 dev branch, ControlNet new version (still work in progress) and AnimateDiff new version (work in progress). If you want to try SparseCtrl, you should checkout specific commits in CN and AD (pls visit the corresponding PR page)

Ph0rk0z commented 9 months ago

I just want my gifs to not be washed out. The reason I bothered to use 2.0 is because double LCM breaks things on dev and not really itching to go back to old "stable" of A1111.

continue-revolution commented 9 months ago

I see. ‘Double LCM’ is actually my due to my PR to A1111. I will create a “no lcm” branch in a few hours and you can use that branch as a workaround.

LCM sampler will be removed in v2.

Ph0rk0z commented 9 months ago

Yea. I was about to just apply https://github.com/continue-revolution/sd-webui-animatediff/pull/381/commits/ba2307df12c6e1a6019b63c805b484976f934804 to master manually and also try https://github.com/continue-revolution/sd-webui-animatediff/pull/409 because I pulled CN today and it updated. Assuming his PR is for normal CN, I don't use dev there.

Ph0rk0z commented 9 months ago

Well.. I did all that.. and still I get a washed out image without LCM. In the console I only see a warning missing keys now.

I am using euler with 20 steps and the default module on default settings, it should be enough in theory.

Ph0rk0z commented 9 months ago

IMG_20240124_103506

Example

JustCann commented 9 months ago

I have the same issue, so is LCM not possible without being completely washed?

continue-revolution commented 8 months ago

might have been fixed. if not let me know