garbled response when hitting enter twice when openAI is being laggy

sircambridge commented 6 months ago

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[ ] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info

- OS: windows
- Continue:
- IDE: VSCode

Description

I had entered a query and just Enter to start, and I got the rainbow gradient border, and it seemed to hang because of the openAI server issues, so I hit enter again, and it looks like two parallel completions started, and the results came back interleaved, which made for a very funny looking response with the tokens mixed up!

To reproduce

its hard to reproduce, since it depends on openAI being laggy, so its some sort of race condition for sure. I saw it twice on the same day during the openAI outage

bug

Log output

To round a numberYou to the nearest can use cent in the JavaScriptMath, you.round() can function use in the JavaScript toMath round.round numbers(). method If. you Here want's to an round example to:

the nearestjavascript cent ,var you num can = multiply the123 number. by456 ; 100var, rounded round it, then divide byNum 100. = Here Math.round's(num how *:

/function  round100To;
Neconsolearest.logCent(round(numbered)Num {
);     return // Math Outputs.round:(number  *123 .46100
``)`

In this / example,  we're100 first;
multiplying the}

console.log(roundTo numberNe byarest Cent100( (12which. shifts345 the6 decimal)); point  two // places Output to: the right 12),. then35 rounding
to`` the`

nearestThis whole number, and then dividing by 100 (which shifts the decimal point back two places to the left). This gives us the original number rounded to the nearest cent.

sestinj commented 6 months ago

Thanks for gathering all of the info here! Looks like what is happening is:

Here we use activeRef.current to watch for a change to the active redux state to turn to false, in order to call abortController.abort.
When the "Cancel" button is clicked for example, it will dispatch(setInactive()) (https://github.com/continuedev/continue/blob/f2fd3a1213a08b5135b9f89d4509eae00ba639b9/gui/src/pages/gui.tsx#L459)
But when the input box is re-submitted, we don't setInactive() because we are immediately making the chat panel active again by sending another message (https://github.com/continuedev/continue/blob/f2fd3a1213a08b5135b9f89d4509eae00ba639b9/gui/src/pages/gui.tsx#L372). This means that the abortController never gets aborted

Probably at line 372 of gui.tsx we could just add dispatch(setInactive()) before streamResponse, but would want to double check that this doesn't cause any problems (e.g. stopping the new request from going through).

Iamshankhadeep commented 6 months ago

got it. @sestinj can you assign this to me?

continuedev / continue