continuedev / continue

⏩ Continue is the leading open-source AI code assistant. You can connect any models and any context to build custom autocomplete and chat experiences inside VS Code and JetBrains
https://docs.continue.dev/
Apache License 2.0
18.21k stars 1.45k forks source link

Duplicate variable declarations in `extensions/vscode/src/activation/activate.ts` #1361

Closed Patrick-Erichsen closed 4 months ago

Patrick-Erichsen commented 4 months ago

Before submitting your bug report

Relevant environment info

- OS: macOS 14.5
- Continue: 0.9.140
- IDE: VSCode

Description

extensions/vscode/src/activation/activate.ts declares resolveVsCodeExtension and vscodeExtensionPromise twice.

This was introduced in #1356.

To reproduce

Run the install-all-dependencies task.

Log output

Error: Command failed: npx vsce package --out ./build patch --no-dependencies
✘ [ERROR] The symbol "resolveVsCodeExtension" has already been declared

    src/activation/activate.ts:17:4:
      17 │ let resolveVsCodeExtension = (_: VsCodeExtension): void => {};
         ╵     ~~~~~~~~~~~~~~~~~~~~~~

  The symbol "resolveVsCodeExtension" was originally declared here:

    src/activation/activate.ts:12:4:
      12 │ let resolveVsCodeExtension = (_: VsCodeExtension): void => {};

✘ [ERROR] The symbol "vscodeExtensionPromise" has already been declared

    src/activation/activate.ts:18:13:
      18 │ export const vscodeExtensionPromise: Promise<VsCodeExtension> = ne...
         ╵              ~~~~~~~~~~~~~~~~~~~~~~

  The symbol "vscodeExtensionPromise" was originally declared here:

    src/activation/activate.ts:13:13:
      13 │ export const vscodeExtensionPromise: Promise<VsCodeExtension> = ne...
sestinj commented 4 months ago

@Patrick-Erichsen this is solved in the preview branch, and I'll push to main later today

spew commented 4 months ago

Duplicate issue here: https://github.com/continuedev/continue/issues/1378