code block font should use editor.fontFamily by default

yuuuxt commented 7 months ago

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info

- OS: win10 x64
- Continue: v.0.8.6
- IDE: vscode

Description

currently the code block looks like this (the font is a default font, not what I'm using in vscode): which applies this css:

so it uses --monaco-monospace-font as the default font. I think the best default setting should be editor.fontFamily, i.e. --vscode-editor-font-family.

(I tried to search --monaco-monospace-font in this repo but didn't find a match)

To reproduce

use arbitrary model to generate some chat that contains a code block
check the css (and try to modify it as described)

Log output

(NA)

sestinj commented 7 months ago

@yuuuxt Looks really nice after doing this, thanks for taking the time to find the variable! It'll be in the next release today

sestinj commented 7 months ago

@yuuuxt ready now in the main release and pre-release. Thanks again for the suggestion, as it also forced me to download the FiraCode font for the first time...enjoying the ligatures so far!

yuuuxt commented 7 months ago

Feels it can also be applied here (inline <code>):

seems it's an easy task so I tried to create a PR here: https://github.com/continuedev/continue/pull/805

yuuuxt commented 7 months ago

Also, I want the chat font to be var(--vscode-font-family), so that it is consistent with the UI of vscode. What do you think?

https://github.com/continuedev/continue/blob/e1291969278597febdf0cce7ce3c9e70fe9dbe95/gui/src/components/markdown/StyledMarkdownPreview.tsx#L62

(created a PR here: https://github.com/continuedev/continue/pull/808)

continuedev / continue