continuous-software / node-virtualmerchant

Node.js SDK for VirtualMerchant payment gateway.
https://www.myvirtualmerchant.com
MIT License
2 stars 3 forks source link

Request for customer IP address in paymentFields. #1

Closed travism closed 7 years ago

travism commented 7 years ago

Hi, I am implementing ecommerce using your module and so far it is working great with one exception.

There is an additional field that convergepay uses in conjunction with their security settings and I'd like to add them to this module.

Would you add the following?

ssl_cardholder_ip

Seems pretty quick and low risk. If you would make this change it would help us out. If you want a PR instead let me know.

Thanks

ghost commented 7 years ago

Your PR would be more than welcome! 😄
Let me know if you can do it and I'll review before merging.

travism commented 7 years ago

Addressed here:

https://github.com/continuous-software/node-virtualmerchant/pull/3

ghost commented 7 years ago

Available in the latest npm package.

$ npm publish
+ virtualmerchant@1.2.1