search

contiv-experimental / demo

Easy cut demos to try contiv [DEPRECATED]
Other
6 stars 25 forks source link

Changes in net_demo_installer script #101

Closed gaurav-dalvi closed 8 years ago

gaurav-dalvi commented 8 years ago

Currently we are hard coding docker version for centos. After this change it will take docker version from docker_version ansible variable.

jojimt commented 8 years ago

LGTM

jainvipin commented 8 years ago

@gaurav-dalvi - why not keep something as default, this would allow people to not force setting this variable. Something that should work as default.

gaurav-dalvi commented 8 years ago

@jainvipin : Default is 1.11.1 See here : https://github.com/contiv/demo/blob/master/net/net_demo_installer#L197

You dont have to set it every time unless you want to override whats there in the script.

jainvipin commented 8 years ago

LGTM