Take contiv_version as Environment variable rather than hard coding in net_demo_installer script and k8s script.

contiv-experimental / demo

Easy cut demos to try contiv [DEPRECATED]

Other

6 stars 25 forks source link

Take contiv_version as Environment variable rather than hard coding in net_demo_installer script and k8s script. #90

Closed gaurav-dalvi closed 8 years ago

gaurav-dalvi commented 8 years ago

Please modify the net_demo_installer script and k8s setup script to take contiv_network_version through command line / environment variable. Right we hard code version string in out scripts which is not ideal way to do it.

reshmagiliyal commented 8 years ago

Issue solved. net_demo_installer and k8s setup scripts are modified to take contiv network version through environment variable. Readme files are modified explaining the steps accordingly.

gaurav-dalvi commented 8 years ago

@reshmagiliyal : Thanks a lot !

gaurav-dalvi commented 8 years ago

Fixed with this : https://github.com/contiv/demo/pull/94