*: fix assignments to make the new version of ineffassign happy

contiv-experimental / volplugin

**EXPERIMENTAL** Contiv Storage: Policy backed Clustered Storage (via Ceph or NFS) for Docker

Other

220 stars 29 forks source link

Closed dseevr closed 8 years ago

dseevr commented 8 years ago

This fixes all the issues which the new version of ineffassign is complaining about.

erikh commented 8 years ago

oh, this is because ineffassign got bug fixes in IT that caused it to detect new ones. I ran into this the other night preparing the DB patch.

dseevr commented 8 years ago

Ahh, that explains... and because we have to invoke ineffassign once for each dir, it was just bailing on the first error.

Do you want me to tidy up all the spots it's complaining about and update the PR?

erikh commented 8 years ago

If you don't mind; yeah.

dseevr commented 8 years ago

Done and passing

erikh commented 8 years ago

hmm; I made several of these fixes already in the db patch but I guess I can rebase them out

erikh commented 8 years ago

LGTM. Simple enough that I'm just going to merge it.