search

contiv-experimental / volplugin

**EXPERIMENTAL** Contiv Storage: Policy backed Clustered Storage (via Ceph or NFS) for Docker
Other
220 stars 29 forks source link

Multiple policies with the same name #469

Open yuva29 opened 8 years ago

yuva29 commented 8 years ago

When a policy with same name is uploaded twice, the user should be informed about the existing policy otherwise it leaves an impression that the new policy is in use which is not the case!

[vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy1.json 
[vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy2.json
erikh commented 8 years ago

Seems good, maybe output the previous and existing policy and confirm? Offer a –y option to skip.

-Erik

From: Yuva Shankar notifications@github.com<mailto:notifications@github.com> Reply-To: contiv/volplugin reply@reply.github.com<mailto:reply@reply.github.com> Date: Wednesday, October 26, 2016 at 10:55 AM To: contiv/volplugin volplugin@noreply.github.com<mailto:volplugin@noreply.github.com> Subject: [contiv/volplugin] Multiple policies with the same name (#469)

When a policy with same name is uploaded twice, the user should be informed about the existing policy otherwise it leaves an impression that the new policy is in use which is not the case!

[vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy1.json [vagrant@mon0 ~]$ volcli policy upload p1 < /opt/golang/src/github.com/contiv/volplugin/systemtests/testdata/ceph/policy2.json

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/contiv/volplugin/issues/469, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AABJ61Qdsik6qJ4yVRKc0MgbakIdz8R_ks5q35QigaJpZM4KheZX.

yuva29 commented 8 years ago

So when someone uploads a new policy with the same name, it will affect all the existing volumes under that policy. I suppose we should not allow this operation itself. WDYT?

erikh commented 8 years ago

no, it will only affect the new volumes.

look at hte runtime upload option for how to affect volumes at runtime.

yuva29 commented 8 years ago

That's right. What I'm trying to say is, its misleading to have volumes that is created from a policy which no more exists. Because, when the user refers the policy, it will be something different than what he used to create volume.

erikh commented 8 years ago

This is what the policy archive is for; it can trace back these changes.

From: Yuva Shankar notifications@github.com<mailto:notifications@github.com> Reply-To: contiv/volplugin reply@reply.github.com<mailto:reply@reply.github.com> Date: Wednesday, October 26, 2016 at 5:21 PM To: contiv/volplugin volplugin@noreply.github.com<mailto:volplugin@noreply.github.com> Cc: Erik Hollensbe ehollens@cisco.com<mailto:ehollens@cisco.com>, Comment comment@noreply.github.com<mailto:comment@noreply.github.com> Subject: Re: [contiv/volplugin] Multiple policies with the same name (#469)

That's right. What I'm trying to say is, its misleading to have volumes that is created from a policy which no more exists. Because, when the user refers the policy, it will be something different than what he used to create volume.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/contiv/volplugin/issues/469#issuecomment-256513834, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AABJ6_GbHzxdP4QkzOr3yGCdR9_RwsaDks5q3-6AgaJpZM4KheZX.