search

contiv / contiv.github.io

Contiv website source code
http://contiv.github.io/
Other
3 stars 65 forks source link

Adding basic contiv container tutorial #121

Closed gaurav-dalvi closed 7 years ago

gaurav-dalvi commented 7 years ago

Signed-off-by: Gaurav Dalvi gaurav1424@gmail.com

gaurav-dalvi commented 7 years ago

@neelimamukiri : Please take a look again.

gaurav-dalvi commented 7 years ago

@rhim and @neelimamukiri : Could you please take a quick look ?

gaurav-dalvi commented 7 years ago

@rhim : I followed this. Only change I made is in md file.

https://github.com/contiv/contiv.github.io/blob/master/CONTRIBUTING.md#submitting-changes

rhim commented 7 years ago

Maybe you need to resolve a conflict? You didn’t change the API ref, did you?

From: Gaurav Dalvi notifications@github.com Reply-To: "contiv/contiv.github.io" reply@reply.github.com Date: Monday, April 3, 2017 at 4:59 PM To: "contiv/contiv.github.io" contiv.github.io@noreply.github.com Cc: "Himanshu Raj (himansh)" himansh@cisco.com, Mention mention@noreply.github.com Subject: Re: [contiv/contiv.github.io] Adding basic contiv container tutorial (#121)

@rhimhttps://github.com/rhim : I followed this. Only change I made is in md file.

https://github.com/contiv/contiv.github.io/blob/master/CONTRIBUTING.md#submitting-changes

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/contiv/contiv.github.io/pull/121#issuecomment-291328744, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMiMKamTO8R5BzZR36hiwZajjMWPY7eJks5rsYfbgaJpZM4MyHXe.

dseevr commented 7 years ago

@rhim I will look at it quickly, the diff doesn't look right... good catch

dseevr commented 7 years ago

@rhim That was just me being a dingus. I copied the latest contivmodel-generated HTML file into the wrong directory. Of course I mess up the easiest part of the doc overhaul process at the very end LOL

@gaurav-dalvi Can you do (on your branch, assuming you're in websrc):

git fetch
git checkout 9f717ac3183f1d9c203d8eaaf44968b8a14d2c33 ../documents/api/contiv.html source/documents/api/contiv.html
git commit -a --amend --no-edit
git push -f
gaurav-dalvi commented 7 years ago

Done. Ready to merge.

dseevr commented 7 years ago

Nice work 👍

I should have reviewed this before when I looked at the documentation issue 😛