search

contiv / contiv.github.io

Contiv website source code
http://contiv.github.io/
Other
3 stars 65 forks source link

fixed typos in container-101 tutorial #97

Closed nategraf closed 7 years ago

dseevr commented 7 years ago

Hi @nategraf,

Thanks for your PR. The HTML files are generated from the corresponding Markdown files under the websrc/source directory, so these changes would be lost the next time someone runs the make build target in websrc/Makefile. The corresponding file for your changes is https://github.com/contiv/contiv.github.io/blob/master/websrc/source/documents/tutorials/container-101.md

It's a bit annoying to get the dev environment set up to run the build command right now. It requires a specific, very old version of Ruby because of gem compatibility issues. I have a Docker-based replacement for the build system 90% done but it's in my low priority queue.

If you can make the changes to the Markdown file I linked and run the build command yourself and checkin both sets of changes, that's great! Otherwise, I am happy to duplicate the corrections you made and credit you in the commit.

Sorry for the hassle, and thank you again for the PR!

dseevr commented 7 years ago

Our technical writer actually did a spellcheck pass of all the tutorials today and happened to get all the errors you found. Thanks for bringing this to our attention regardless!