search

contiv / libOpenflow

Apache License 2.0
21 stars 45 forks source link

Request to fix a typo in flowmod.go #33

Open vanytsvetkov opened 2 months ago

vanytsvetkov commented 2 months ago

My apologies, however, are you sure that this code should look exactly like it does?

https://github.com/contiv/libOpenflow/blob/d967b14cc6889aa008ad564b5617abc272c9be15/openflow13/flowmod.go#L99-L102

Perhaps you wanted to write something like:

        binary.BigEndian.PutUint32(bytes[n:], f.OutPort) 
        n += 4 
        binary.BigEndian.PutUint32(bytes[n:], f.OutGroup) 
        n += 4

Just check the source code of OpenvSwitch to be completely sure.

        ofm->out_port = ofputil_port_to_ofp11(fm->out_port);
        ofm->out_group = htonl(fm->out_group);