search

contiv / netplugin

Container networking for various use cases
Apache License 2.0
515 stars 177 forks source link

Init global settings from object store #1043

Closed tiewei closed 6 years ago

tiewei commented 7 years ago

Currently netplugin is trying to init from default settings if global setting is not ready or wrong, and when the settings don't match it will re-init netplugin. This is very easy to go wrong when there are resources created before global settings are ready. This commit makes netplugin wait until the global settings ready, and initiate itself according to it. If the global settings are mis-match, it will return error.

Signed-off-by: Wei Tie wtie@cisco.com

kahou82 commented 7 years ago

Can you add unit test?

tiewei commented 7 years ago

UT will be followed

tiewei commented 7 years ago

test case added

unclejack commented 7 years ago

build PR

tiewei commented 7 years ago

build PR

tiewei commented 7 years ago

build PR

tiewei commented 7 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

@dseevr @kahou82 @unclejack @chrisplo please let me know if it meets the comments

chrisplo commented 6 years ago

All my comments have been addressed, will defer to the reset of the comments

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR

tiewei commented 6 years ago

build PR