Closed tiewei closed 6 years ago
build PR
build PR
build PR
build PR
Nice work! Had some comments. Also, did not review the 21 new files vendored in vendor/github.com/urfave
.
The error Error message did not yield stack trace with CONTIV_TRACE set
in core/error_test.go
need to refer CONTIV_TRACE
as CONTIV_TRACE
is not used anymore. Can be corrected in a follow-up PR.
This commit refactors netplugin CLI, it uses "github.com/urfave/cli" now in order to provide configuration from CLI and environment vars, and provides easy way to load from config files too. In details, this commit introduced:
Signed-off-by: Wei Tie wtie@cisco.com