contiv / netplugin

Container networking for various use cases
Apache License 2.0
513 stars 177 forks source link

contiv k8s container now tagged with git version #1082

Closed chrisplo closed 6 years ago

chrisplo commented 6 years ago

the container build can leverage other new tasks to simplify the build script considerably

drive-by: found the release notes for the container release was wrong

Signed-off-by: Chris Plock chrisplo@cisco.com

chrisplo commented 6 years ago

build PR

dseevr commented 6 years ago

build pr

unclejack commented 6 years ago

make host-build-docker-image is failing for me with this branch:

Successfully built 0594eb131267
Successfully tagged netplugin-build:1.1.0-rc.1-400-ga0a08e2
docker rm netplugin-build 2>/dev/null || :
c_id=$(docker create --name netplugin-build netplugin-build:1.1.0-rc.1-400-ga0a08e2) && \
for f in netplugin netmaster netctl contivk8s netcontiv; do \
        docker cp ${c_id}:/go/bin/$f bin/$f; done && \
docker rm ${c_id}
bf3638a1e74e0d196b4f2274f863eac1aeeb179d2990107d58c7c08d0db5a62c
tar: scripts/netcontain/bin: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
Makefile:257: recipe for target 'host-build-docker-image' failed
make: *** [host-build-docker-image] Error 2
unclejack commented 6 years ago

build PR

chrisplo commented 6 years ago

@unclejack I'm puzzled, line 257 is nowhere near the target you are running: https://github.com/chrisplo/netplugin/blob/master/Makefile#L257 I deleted the binaries in bin and in scripts/netcontain/bin and reran without an issue Repeated that after a merge with master.

chrisplo commented 6 years ago

build PR

unclejack commented 6 years ago

build PR