netmaster cli refactor

[tiewei]

Refactor netmaster cli to use "github.com/urfave/cli", it brings benefit like setting forwarding mode, infra type and network mode, allows setting multi etcd/consul endpoints and using SSL, enabling syslog,json log and multi log levels.

Signed-off-by: Wei Tie wtie@cisco.com

[tiewei]

TODO: update container entrypoint scripts

[dseevr]

build pr

[tiewei]

build PR

[dseevr]

@tiewei How do you feel about raising an error if etcd and consul endpoints are set? Right now it says "consul endpoints are ignored if etcd endpoints are set"... if both of them are set, we can't really determine what the user intent was IMO. I think we should just explode in that case.

[tiewei]

@chrisplo mentioned that as well in last commit ... i'll error it out then

[tiewei]

build PR

[unclejack]

What release is this meant to be included in? It'd be nice to deprecate the old flags instead of removing them. This should make it easier if we make a 1.2 release which is still backwards compatible and some users upgrade an existing setup. What do you think?

[tiewei]

Most old flag was kept except --cluster-store due to the schema of url change, yes 1.2 would be ideal for this type of changes

[tiewei]

Build PR

[chrisplo]

overall substance looks good, just some style nits