search

contiv / netplugin

Container networking for various use cases
Apache License 2.0
513 stars 177 forks source link

netctl: provide fallback for user.Current #1092

Closed unclejack closed 6 years ago

unclejack commented 6 years ago

This PR fixes the static netctl binary. This makes it possible to run a statically built netctl binary without a panic.

dseevr commented 6 years ago

Since I don't think we intend to ever go back to non-static binaries, can we just remove the user.Current call entirely?

unclejack commented 6 years ago

build PR

unclejack commented 6 years ago

@dseevr: In case we start building binaries for other platforms, I'd rather have it there.

I've modified the error message.

unclejack commented 6 years ago

build PR

dseevr commented 6 years ago

build pr

chrisplo commented 6 years ago

build PR

unclejack commented 6 years ago

build PR

unclejack commented 6 years ago

This is green now. I'll merge.