search

contiv / netplugin

Container networking for various use cases
Apache License 2.0
512 stars 177 forks source link

modified burst value #1126

Closed wangxf1987 closed 6 years ago

wangxf1987 commented 6 years ago

Bugfix: modified that check burst value when run the function ValidateNetprofile.

  1. the burst is hard code
  2. the burst can't set 10% of rate
  3. if want to achieve the desired performance, it's best to equal the value of rate

Description of the changes

Type of fix:

Fixes #

Please describe:

  1. No matter how much the value of rate is set, The value of burst cannot exceed 10486.
  2. If rate is 100mbps and the burst is 10485, Actually, the bandwidth only 50mbps. image
  3. If set the rate is 1000mbps and the burst is 10485, the result is same to above. image

    TODO

    • [ ] Tests
    • [ ] Documentation