Closed wangxf1987 closed 6 years ago
You will need to rebase your code on the latest master
code in the netplugin repo. You are missing about ~9 commits that exist on our master
branch
OK, I will be fix. and commit again.
You can git rebase master
on this branch and force push to Github. You don't need to open a new PR to make changes
@dseevr I will be push the change to the master branch directly, right?
You push to the remote/branch you used to open the PR. In the case of #1139, it's wangxf1987/master
The general workflow is:
git remote add yourusername git@github.com:yourusername/netplugin.git
git checkout -b feature_branch
git push -u yourusername feature_branch
To edit the PR, just edit feature_branch
locally and git push
your changes. If there are new changes on the main repo since you created your feature branch, you can: git checkout master && git pull && git checkout feature_branch && git rebase master
. After you resolve merge conflicts (if there any), you can git push -f
to overwrite your branch on github (-f
is necessary because you have altered history on your branch). If you just add a new commit on top of your existing commits, you can just run git push
to update your branch on github.
@liucimin thx, cimin. @dseevr I have to renew a PR, because my local repo and fork repo already has been remove. so the PR head fork that show unknown repository. Please help me delete or close #1138 #1139. thanks again.
You can close your own Pull Requests. Just click "Close Pull Request" at the bottom right.
Description of the changes
Type of fix: Bug Fix
Fixes #1137
Please describe:
TODO