search

contiv / netplugin

Container networking for various use cases
Apache License 2.0
515 stars 178 forks source link

Cleanup references to fwd_mode param as netplugin parameter #706

Open neelimamukiri opened 7 years ago

neelimamukiri commented 7 years ago

fwd_mode needs to be passed to https://github.com/contiv/netplugin/blob/master/scripts/netContain/contivNet.sh#L114

abhi commented 7 years ago

@neelimamukiri just to correct here. fwd_mode is global knob. It is not passed to netplugin. Its set using netctl set global --fwd-mode routing similar to aci

neelimamukiri commented 7 years ago

Okay thanks for the clarification. That means it needs to be cleared as a parameter from the shell script to avoid confusion. As per our discussion this was removed intentionally at https://github.com/contiv/netplugin/commit/1140c8dfcda31683d3899889b40c83355aa7830a#diff-9d2be7734474ea678e9d1d6587b9067d

So we need to:

  1. Update the documentation to reflect the fwd-mode setting
  2. Cleanup remnants of fwd_mode in the netContain docs and script
neelimamukiri commented 7 years ago

Docs have been updated at https://github.com/contiv/netplugin/tree/master/install/k8s. I've updated the summary to reflect the cleanup task to remove references to fwd_mode as netplugin parameter in the documentation and scripts. I don't think we need to do that for beta.