search

contiv / ofnet

Ofnet is openflow networking library
Other
79 stars 73 forks source link

Makefile: add missing packages to check #74

Closed unclejack closed 7 years ago

unclejack commented 7 years ago

This PR makes a change to ensure we check all packages.

unclejack commented 7 years ago

We need to address this issue before we can merge this PR:

ovsSwitch/ovsSwitch.go:275: suspect or: sw.netType != "vxlan" || sw.netType != "vrouter"
ovsSwitch/ovsSwitch.go:314: suspect or: sw.netType != "vxlan" || sw.netType != "vrouter"
abhi commented 7 years ago

@unclejack lets skip ovsSwitch for now. We are using the package in netplugin and not in ofnet.However the reason this is kept was we need to eventually start using it here. Hence its being ignored. libpkt was a a testing utility we wrote and didnt get a chance to use it to test ofnet. We can skip building that for now as well.

unclejack commented 7 years ago

@abhinandanpb: This is more about the basic checks to ensure the code is OK, regardless of where it's being used.

unclejack commented 7 years ago

This PR is green now. I've added a commit to add missing .PHONY targets to the Makefile.

PTAL

unclejack commented 7 years ago

I'll merge this now. It doesn't make any changes to the code.