contiv / vpp

Kubernetes CNI plugin based on FD.io VPP
https://contivpp.io
Apache License 2.0
249 stars 114 forks source link

Need to update to CRI runtime API v1alpha2 #1043

Closed mestery closed 6 years ago

mestery commented 6 years ago

As part of trying to get ligato/cn-infra, ligato/vpp-agent and contiv/vpp up the kubernetes-1.11, a breaking API change for CRI was introduced. The previous API was v1alpha1, and it has been upgraded to v1alpha2.

I tried to make an attempt at this change earlier this week, but I was unable to complete it. Someone with more knowledge of the CRI stuff inside of contiv/vpp can likely make this change much faster.

This will be required to upgrade the kubernetes dependency to at least 1.10 (and ideally 1.11) where we can make use of CRDs.

/cc @jhnbrns @jmedved @ondrej-fabry

jmedved commented 6 years ago

We can deprecate CRI for now and take it out of the build. It’s not used. IF& when we use it in the future, we will re-introduce the latest version at that time.

/Jan

From: Kyle Mestery notifications@github.com Reply-To: contiv/vpp reply@reply.github.com Date: Friday, August 17, 2018 at 6:57 PM To: contiv/vpp vpp@noreply.github.com Cc: "Jan Medved (jmedved)" jmedved@cisco.com, Mention mention@noreply.github.com Subject: [contiv/vpp] Need to update to CRI runtime API v1alpha2 (#1043)

As part of trying to get ligato/cn-infra, ligato/vpp-agent and contiv/vpp up the kubernetes-1.11, a breaking API change for CRI was introduced. The previous API was v1alpha1, and it has been upgraded to v1alpha2.

I tried to make an attempt at this change earlier this week, but I was unable to complete it. Someone with more knowledge of the CRI stuff inside of contiv/vpp can likely make this change much faster.

This will be required to upgrade the kubernetes dependency to at least 1.10 (and ideally 1.11) where we can make use of CRDs.

/cc @jhnbrnshttps://github.com/jhnbrns @jmedvedhttps://github.com/jmedved @ondrej-fabryhttps://github.com/ondrej-fabry

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/contiv/vpp/issues/1043, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADr5VLNii8Hj69vaeWPTPraIcEUVMasdks5uR3RzgaJpZM4WCYiG.

brecode commented 6 years ago

Closing this since Contiv-CRI is now deprecated #1047 @mestery @jmedved