Some support for unicode-range and @font-face{font-weight}.

contivero / hasmin

Hasmin - A Haskell CSS Minifier

BSD 3-Clause "New" or "Revised" License

57 stars 4 forks source link

Some support for unicode-range and @font-face{font-weight}. #9

Open galenhuntington opened 4 years ago

galenhuntington commented 4 years ago

Ref #8.

I don't know or really understand this codebase, but I gave it a shot.

unicode-range now at least doesn't get mangled, although the parser is primitive and doesn't try to minify.
font-weight mostly works, but font-weight: normal bold gets changed to font-weight:700, which is wrong, and I haven't yet figured out why normal gets eaten. One question is whether it's better to leave this bug or defer support.

contivero commented 4 years ago

Thanks! My apologies for the silence, you caught me in a very busy time in my life unfortunately :/ I'll try to work off this to add support while fixing the bug you mentioned. Do you need this fast, or can you wait for me a bit longer?

On a side note, do you mind me asking in which context are you using this project (is it the library or the stand alone executable?). Just curious as to how people are using this.

galenhuntington commented 4 years ago

There's no particular hurry from my end. The above code changes sufficed, and anyway I gave up trying for pure Haskell solutions for that project, and went with Node libraries, largely because I needed Node in the stack anyway for Stylus. I was using the Hasmin library, called from a Shake build file.