Insert of second image corrupts sixel graphics

contour-terminal / contour

Modern C++ Terminal Emulator

http://contour-terminal.org/

Apache License 2.0

2.39k stars 102 forks source link

Open Yaraslaut opened 1 year ago

Yaraslaut commented 1 year ago

Contour Terminal Emulator 0.3.11-master-cd0aa937

Github: source code cloned

RHEL

x86-64

julia

No response

sixel rendering is broken

To reproduce this behavior size of the terminal in pixels must exceed 1080p

christianparpart commented 1 year ago

I am looking at this from my phone, sorry for this. Is the problem that at the end of the scroll, the background image is shining through?

christianparpart commented 1 year ago

I wonder if this is only happening on qml branch or also on master. 🤔

Yaraslaut commented 1 year ago

I wonder if this is only happening on qml branch or also on master. thinking

No, I am seeing same behaviour on current master as well Contour Terminal Emulator 0.3.11-master-99d6e65a

christianparpart commented 1 year ago

Ok thx. This was just a hunch.

Yaraslaut commented 1 year ago

I am looking at this from my phone, sorry for this. Is the problem that at the end of the scroll, the background image is shining through?

The problem is that after i insert second image first becomes corrupted and i see this:

Yaraslaut commented 11 months ago

Can be reproduced with one image, example julia code f = Figure(resolution=(2000,1100)); ax = Axis(f[1,1]); lines!(ax,rand(100)); f

christianparpart commented 7 months ago

We figured out that #1458 is only a interim workaround but not an ultimate fix.

What should be done to close this ticket is to probably have a atlas texture size with the dimension of the current screen this window is living in.

if the window is moved to another screen (or the physical screen size is changed), then the texture atlas needs to be re-allocated
if the font size is changed only, then the texture atlas itself only needs to be re-addressed and re-initialized but not re-created.