contour-terminal / contour

Modern C++ Terminal Emulator
http://contour-terminal.org/
Apache License 2.0
2.38k stars 102 forks source link

fix to build with boxed-cpp #1301

Closed topazus closed 10 months ago

topazus commented 10 months ago

Description

The PR is related to https://github.com/contour-terminal/boxed-cpp/pull/9

How Has This Been Tested?

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

topazus commented 10 months ago

The error appeared in Ubuntu 20.04 was seemingly caused by the reason that GCC 9 does not support C++ 20 concepts.

Yaraslaut commented 10 months ago

The error appeared in Ubuntu 20.04 was seemingly caused by the reason that GCC 9 does not support C++ 20 concepts.

I see that g++10 is there https://packages.ubuntu.com/focal/g++-10 We can update GitHub action to compile with gcc-10

Yaraslaut commented 10 months ago

@topazus Can you update github action then please? If you are bussy i can do it as well

topazus commented 10 months ago

I do not have a compuer at hand right now. Grateful if you do this. @Yaraslaut

Yaraslaut commented 10 months ago

@topazus I updated PR, builds are fine now, if you fill that PR is no longer in draft, make it then ready for review to proceeed with merging