search

contour-terminal / contour

Modern C++ Terminal Emulator
http://contour-terminal.org/
Apache License 2.0
2.37k stars 102 forks source link

Dont force redraw on hard reset for status line #1314

Closed Yaraslaut closed 9 months ago

Yaraslaut commented 9 months ago

Closes https://github.com/contour-terminal/contour/issues/1303

christianparpart commented 9 months ago

Build / Ubuntu Linux 22.04

This one will keep failing, we have to ignore this check (for now), and merge despite this. But the rest should get green. Weird, that it's not. (can also have a look later, if needed :) )

EDIT:

/Users/runner/work/contour/contour/src/vtbackend/Terminal_test.cpp:197:17: error: no member named 'forceRedraw' in 'vtbackend::Terminal'
    mc.terminal.forceRedraw({});
    ~~~~~~~~~~~ ^

That's why. But yeah, I'd suggest we keep this function (and make sure it's working). We can attach that functionality to its own action (ForceRedraw)

Yaraslaut commented 9 months ago

Alrigh, will save it and change how it works then

Yaraslaut commented 9 months ago

Build / Ubuntu Linux 22.04

This one will keep failing, we have to ignore this check (for now), and merge despite this. But the rest should get green. Weird, that it's not. (can also have a look later, if needed :) )

EDIT:

/Users/runner/work/contour/contour/src/vtbackend/Terminal_test.cpp:197:17: error: no member named 'forceRedraw' in 'vtbackend::Terminal'
    mc.terminal.forceRedraw({});
    ~~~~~~~~~~~ ^

That's why. But yeah, I'd suggest we keep this function (and make sure it's working). We can attach that functionality to its own action (ForceRedraw)

So i just deleted call to force redraw

christianparpart commented 9 months ago

Check Changelog / Check Changelog Action (pull_request)

FYI: This is failing (and a new check :D) because you did not modify the metainfo.xml. this is a pretty dump check, it simply tests if it was subject to the PR diff.

If no changelog entry is needed, simply add no changelog label to the PR to get that check ignored (go green).