Clear invalid iCCP profiles - Githubissues

contour-terminal / contour

Modern C++ Terminal Emulator

http://contour-terminal.org/

Apache License 2.0

2.32k stars 102 forks source link

Clear invalid iCCP profiles #1364

Closed cqexbesd closed 7 months ago

cqexbesd commented 7 months ago

Description

On each startup libpng warns:

libpng warning: iCCP: known incorrect sRGB profile ((null):0, (null))

This is due to the iCCP profile (embedded in a PNG) being invalid in some way. The file is embedded in the contour binary, not opened at run time.

There are two PNGs fitting this criteria:

src/contour/res/images/contour-logo-256.png
src/contour/res/images/contour-logo.png

Using mogrify I fixed and/or removed the iCCP profile so the warning does not occur.

Motivation and Context

Why is this change required? What problem does it solve?

The warning on each startup is annoying and may be worrying for users who don't know its meaning or severity.

How Has This Been Tested?

I ran contour after fixing the PNGs and it works for me

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

[X] I have read the CONTRIBUTING document in my spoken language, and understand the terms
[ ] I have updated (or added) the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have gone through all the steps, and have thoroughly read the instructions

christianparpart commented 7 months ago

Many thanks, @cqexbesd ! :-)