search

contour-terminal / contour

Modern C++ Terminal Emulator
http://contour-terminal.org/
Apache License 2.0
2.32k stars 101 forks source link

Small cleanup of cmake #1422

Closed Yaraslaut closed 5 months ago

Yaraslaut commented 5 months ago

Small cleanup of cmake files

Yaraslaut commented 5 months ago

I realized that we use older versions of cmake in some distros and can not use target sources with FILE_SET yet, thus closing PR

christianparpart commented 5 months ago

@Yaraslaut would it be possible to upgrade cmake on such platforms - for CI?

IMHO it should be all good for any supported platform as long as we can build for that platform on CI.

Ubuntu 18.04 also doesn't have a proper C++20 aware compiler out of the box, and yet we compile using one for Ubuntu 18.04 as well. I would be fine with using a more recent cmake as long as it doesn't break CI and existing downstream distributions (SuSE, Fedora, Void, NixOS). :)

Yaraslaut commented 5 months ago

@Yaraslaut would it be possible to upgrade cmake on such platforms - for CI?

IMHO it should be all good for any supported platform as long as we can build for that platform on CI.

Ubuntu 18.04 also doesn't have a proper C++20 aware compiler out of the box, and yet we compile using one for Ubuntu 18.04 as well. I would be fine with using a more recent cmake as long as it doesn't break CI and existing downstream distributions (SuSE, Fedora, Void, NixOS). :)

i think this is pointless at the moment to use newer versions of cmake since we do not get any benefits and potentially loosing support of some distros