Closed saliaku closed 5 months ago
is there anything more that needs to be done ?
why are some checks getting failed , what can I do to make it work ?
You can address the editorconfig checks, when you click on Details of that check you will see what needs to be changed, everything else is fine
i have made changes to the .gitignore file
why are some checks getting failed , what can I do to make it work ?
They're not running because only src/ has not been touched. We maybe should tweak that outside of that PR at some point.
Description
closes #1437
Describe your changes in detail
Motivation and Context
Why is this change required? What problem does it solve?
How Has This Been Tested?
Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.If you're unsure about any of these, don't hesitate to ask. We're here to help!
CONTRIBUTING
document in my spoken language, and understand the terms