search

contour-terminal / contour

Modern C++ Terminal Emulator
http://contour-terminal.org/
Apache License 2.0
2.31k stars 100 forks source link

Replace all occurrences of OS/X #1462

Closed fingolfin closed 4 months ago

fingolfin commented 4 months ago

The Macintosh operating system underwent many name changes over the years, from being nameless to "System" to "Mac OS" to "OS X" to "macOS".

But at no point in time was it ever called "OS/X" :-)

christianparpart commented 4 months ago

Many thanks, @fingolfin.

I think I'm used to name it like that from the time it was named like that (just without the slash):

image [1]

Not sure were the slash is coming from, in my memories :)

fingolfin commented 4 months ago

Did a quick review, what I would NOT do is to edit existing changelog,

But why not? Would you not fix typos in them either?

but add new entry for the change of naming

OK, if you want a changelog entry for a typo fix, I am happy to add it -- except I have no idea how. I am guessing metainfo.xml might be the changelog file (though I am not sure given its name)? But what is the format, where would this be added?

christianparpart commented 4 months ago

https://github.com/contour-terminal/contour/blob/cdb2e16d29fff252a3b95977c9dc03fd2f96e2a0/metainfo.xml#L107-L113

Hey. This is going to be the changelog for the next release. You can simply add yourself at the end of it.

Changelogs can of course be typo-fixed, but I remember from other big open source projects that change logs are only about to be changed for present/future entries, not touching past entries. So I think that's a philosophy thing :)

christianparpart commented 4 months ago

Hey @fingolfin. Can I help you with anything?

fingolfin commented 4 months ago

I don't time to work on this outside of weekends. Anyway, this is a trivial search&replace change. Feel free to finish the PR in whichever way you want it, or to close it / do your own version of it.

christianparpart commented 4 months ago

I've added the changelog entry after the merge. Many thanks @fingolfin for your contribution and support. :-)