search

contour-terminal / contour

Modern C++ Terminal Emulator
http://contour-terminal.org/
Apache License 2.0
2.31k stars 100 forks source link

Monitor scaling behaves weird on Windows. #1465

Closed ferdinandyb closed 3 months ago

ferdinandyb commented 4 months ago

Contour Terminal version

Contour Terminal Emulator 0.4.3.6442

Installer source

GitHub: release page

Operating System

Windows

Architecture

x86-64

Other Software

No response

Steps to reproduce

Have two monitors where one is set to 100% scale and the other to 125% scale. Open contour on the 100% scale monitor and move it to the other one.

Expected Behavior

No response

Actual Behavior

This is how contour looks on the 100% scale monitor: image

And this is how it looks on the 125% scale monitor: image

The horizontal distance between characters is somehow squished.

Here's another view on the 125% scale monitor, where the top one was opened on the 125% scale monitor, while the other one was opened on the 100% scale and move to the 125% scale: image

Additional notes

No response

Yaraslaut commented 4 months ago

Can be connected to https://github.com/contour-terminal/contour/issues/940

christianparpart commented 3 months ago

This is an interesting one. I actually implemented responding to monitor changes (and thus, responding to DPI changes) in the frontend code. But I obviously did something wrong there. At least it worked back then when we only used Qt Widgets. We need to re-assure how this should be working when using QML I think... 🤔

p.s.: for reference https://stackoverflow.com/a/63943742/386670

ferdinandyb commented 3 months ago

@christianparpart I just grabbed the latest msi from https://github.com/contour-terminal/contour/actions/runs/8314676103, because I thought #1487 might fix this and indeed it did.

Yaraslaut commented 3 months ago

@christianparpart I just grabbed the latest msi from https://github.com/contour-terminal/contour/actions/runs/8314676103, because I thought #1487 might fix this and indeed it did.

Thanks for checkin @ferdinandyb :) I am closing this issue then