contour-terminal / contour

Modern C++ Terminal Emulator
http://contour-terminal.org/
Apache License 2.0
2.31k stars 100 forks source link

Introduce boxed types for margins and handling of input #1491

Closed Yaraslaut closed 3 months ago

Yaraslaut commented 3 months ago

Add boxed types for window margins and input handling

Yaraslaut commented 3 months ago

For horizontal and vertical margins I totally agree and understand. For Handled it took me a while to see the benefit. I think there actually is one, because we encode the meaning of that boolean. So 👍 :)

Concerning Handled, yes, i added it to see the meaning of the bool value, since it is not obvious what this bool means when returned from one function into another