search

contraband / autopilot

cf plugin for hands-off, zero downtime application deploys
Apache License 2.0
130 stars 43 forks source link

Copy the environment variable from the old to the new #29

Closed fallflame closed 7 years ago

fallflame commented 8 years ago

Currently, the User-Provided environment variables get lost when we use the zero-downtime-push

Here I set them for the new app.

dan-kirberger commented 8 years ago

I'm curious - what is your typical workflow with setting environment variables? I assume the vars you are trying to copy were added manually, not from the manifest?

fallflame commented 8 years ago

Hi,

The environment variables may contain some credentials. We don't want to put them in the manifest file, which we push to the git repo.

xoebus commented 7 years ago

Thanks for the pull request! Unfortunately I want to keep autopilot as small and simple as possible. This relies on the manifest always being the source of truth.

You could merge the credential-free manifest from source control with credentials from a secret store just before you push. Feel free to fork if this doesn't work for you.