contraband / autopilot

cf plugin for hands-off, zero downtime application deploys
Apache License 2.0
130 stars 43 forks source link

support default manifest path and application name like `cf push` does #41

Open cmloegcmluin opened 6 years ago

cmloegcmluin commented 6 years ago

We use the autopilot plugin and think it's great, but thought it would be greater if we didn't need to specify the app name or manifest path if:

That way, cf push could be swapped out for zero-downtime-push with no changes.

We are Pivots from Pivotal Tokyo on the beach and are new to Go, so we may not have written the most idiomatic code. We also used some CF CLI internals; it seemed appropriate but again not quite sure. Happy for any feedback.

Douglas Blumeyer & Robert Gravina

xoebus commented 6 years ago

Thank you for submitting this! I'm sorry for the delay. I'll try and get around to reviewing it soon.

zachberger commented 6 years ago

@xoebus Any update on this?

xoebus commented 6 years ago

Hi @zachberger, sorry I haven't had a chance to get to this yet. Unfortunately I'm swamped for the next few weeks too. I like the feature and would probably merge it but don't have time to look into the code in detail just yet.