search

contraband / autopilot

cf plugin for hands-off, zero downtime application deploys
Apache License 2.0
130 stars 42 forks source link

Add ability to tail application logs during start #43

Closed aeijdenberg closed 6 years ago

aeijdenberg commented 7 years ago

Fixes https://github.com/contraband/autopilot/issues/38.

Also fixes some panics that would occur when invoked with no arguments.

The change itself isn't very big, and is in the first commit and follows the technique suggested in https://github.com/cloudfoundry/cli/issues/1031#issuecomment-267966014.

The second commit took the longest - and is my attempt to update Godep - I think this builds cleanly now.

aeijdenberg commented 7 years ago

I forgot to actually document how to invoke, simply add --show-app-log

aeijdenberg commented 6 years ago

@xoebus - this repo seems a little quiet...

Are you still accepting PRs for review, or do you have other suggestions?

xoebus commented 6 years ago

You're right: there's hasn't been much progress here lately. Due to the (hopefully) imminent start of the Cloud Controller work which will allow these features natively I'm probably only going to merge fixes rather than new features from now on but I'll try and get through the existing pull requests.

xoebus commented 6 years ago

@aeijdenberg Thank you so much for you patience. I've cherry picked this commit onto my master and resolved some conflicts but there were import issues in the dependencies that I've had to revert. The problem is in the CLI import code but they've already fixed the problem on master. I'll wait for the next CLI release and try again.

Original Commit Revert

Dependency error:

Solving failure: No versions of github.com/cloudfoundry/bytefmt met constraints:
        master: Could not introduce github.com/cloudfoundry/bytefmt@master, as its subpackage github.com/cloudfoundry/bytefmt does not contain usable Go code (*pkgtree.NonCanonicalImportRoot).. (Package is required by code.cloudfoundry.org/cli@v6.33.0.)
xoebus commented 6 years ago

The CLI team has said that they'll be releasing today or tomorrow so I should be able to look at this soon.

aeijdenberg commented 6 years ago

Abandoning this PR in favor of https://github.com/contraband/autopilot/pull/44, where I think I've addressed the dep issues.

dan-kirberger commented 6 years ago

@xoebus - Could you share any info on this Cloud Controller work?

xoebus commented 6 years ago

@dan-kirberger https://docs.google.com/document/d/116I_mOWjZcPeIbUvvsh-jAcwpoE_mGPD_SkCel5xXuU/edit