contraband / autopilot

cf plugin for hands-off, zero downtime application deploys
Apache License 2.0
130 stars 42 forks source link

Created the keep-old-app flag #54

Open adamsiemion opened 6 years ago

adamsiemion commented 6 years ago

I have created a new arg flag keep-old-app, which skips deleting of the old app.

This was required by the project which currently work on. We use Pivotal Cloud Foundry (PCF) container-to-container networking and Eureka service registry.

The way we use autopilot is the following (let's assume the service we are redeploying is called test-service:

mibollma commented 6 years ago

I would find it more useful to change the flag to an enumeration e.g. -old-app=remove|stop|none where remove is the default, none solves your case and stop solves my case https://github.com/contraband/autopilot/issues/53. What do you think?

I'm willing to help, unfortunately new to the language go.

adamsiemion commented 6 years ago

@mibollma Good work on the code changes! I support the idea. Actually recently we have moved away from this plugin to the tool that does the same thing but just calls cf with appropriate commands (https://github.com/adamsiemion/pcf-zerodowntimedeploy). The main reason is the fact that we use plugins for Cloud Foundry in Jenkins and Urban Code Deploy, which only support the push command and does not allow to use zero-downtime-push instead.

mibollma commented 6 years ago

@adamsiemion Thanks for your support. Hopefully @xoebus will find the time to take a look.