search

contradb / contra

Find and share contra dances.
http://contradb.com
GNU Affero General Public License v3.0
13 stars 5 forks source link

R/L shoulder param for hey #213

Open djpohly opened 6 years ago

djpohly commented 6 years ago

Hey figure has a parameter for who starts, but not by which shoulder from what I can see. Default right w/option of left would seem to make sense.

dcmorse commented 6 years ago

I'm very reluctant to include the parameter because I feel like the shoulder is implicit from who's in the minor set, and who leads. It feels like denormalizing the hey encoding.

Now if we could derive the proper shoulder, and print it, without the user having to specify it, that'd be neat. That seems like it'd require a kind of dance interpreter in order to suss out though, because you gotta know if the lady is on the right or the left. That's a major project - but it could also be used for dance validation and figure visualization, so I think it makes sense at some point.

I'm impressed you managed to delve into the guts of libfigure without help. That's kinda amazing!

See also: https://github.com/dcmorse/contra/issues/122

djpohly commented 6 years ago

(You should have seen the attempt I made at making it easy to add backward-compatible parameters... before I noticed that you just use database upgrade scripts for that. Yikes!)

I don't think the necessary information to derive it is always present. Consider "Hey There" by Tom Hinds, which has the sequence:

How many blanks would we have to fill to make this unambiguous? An experienced caller or dancer would likely guess correctly, but it would still be a guess.