Closed cranhandler closed 6 years ago
Yeah, agree that this is needed. It blew up in complexity towards the end of the dialect project and I cut it. I don't think there's an issue for it yet.
I'd also like to support "turn by the (right|left) shoulder", which would be in the menus as "turn by the shoulder".
The tricky thing is having a UI name separate from the thing that gets rendered in the figure string.
Hey, what about a rewrite of dialects where we could have advanced move substitutions, and it'd look something like:
gyre -> menu as 'turn by the shoulder' and format as '$who turn by the
$direction shoulder'
This isn't the only affected figure. Renames of zig zag and allemande orbit have no effect in rendered figure text, because those words don't actually appear in the figure text. If you want to see the words "giz" and "gaz" in your figures instead of "zig" and "zag", you're out of luck.
There's enough here to make a little domain specific language. It'd be hard for a user to understand, but they're not the only customers. There are hundreds of lines devoted to writing these strings in javascript, and if there were a more succinct language it'd simplify that file too.
hm.
Including %s in the gyre substitution substitutes where the shoulder goes. This gets documented in the pop up dialog.
Hooray!
On Thu, May 17, 2018 at 6:53 AM, Dave Morse notifications@github.com wrote:
Proposal
Including %s in the gyre substitution substitutes where the shoulder goes. This gets documented in the pop up dialog.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/contradb/contra/issues/342#issuecomment-389840439, or mute the thread https://github.com/notifications/unsubscribe-auth/APbjzU8V4H7j3JEZ4IXHLp0gyhVxcW5Lks5tzWTAgaJpZM4TZD1B .
-- Allison Jonjak, M.S., E.I.T. allisonjonjak@gmail.com allisonjonjak.com
Please suggest improvements to this dialog for clarity, if any come to mind. @cranhandler @chetgray
Proposed language: "if you need the direction to show up anywhere but after the move name, use '%S' to show us where you want it."
My preferred dialect, and one that I expect will be quit common, is replacing 'gyre' with 'right shoulder round' | 'left shoulder round'.
Currently, because libfigure knows the figure as gyre which is modified by right or left, my dialect substitution of 'shoulder round' results in dances rendering
'shoulder round left shoulder' or 'shoulder round right shoulder' whereas I would prefer 'left shoulder round' or 'right shoulder round'
Is there a convenient way we can add a selector that lets me indicate (for my dialect) whether the right/left modifier displays before or after the figure name?
Example dance: http://contradb.com/dances/375
currently using: gyre
currently using: shoulder round