search

contradb / contra

Find and share contra dances.
http://contradb.com
GNU Affero General Public License v3.0
13 stars 5 forks source link

shared ezfilter #620

Closed dcmorse closed 4 years ago

dcmorse commented 4 years ago

Below the "Verified" ezfilter, add a "Shared" ezfilter:

Updated!

Shared

Obsolete version for archival purposes:

Shared

"by me" is disabled/hidden when no user is logged in, as in #618. Similarly, "omnicient" is disabled/hidden when the user is not an admin.

(this is part of the #563 story)

dcmorse commented 4 years ago

An unfortunate story, starring me.

To ensure that the new "anything by me" checkbox was working properly, I created a private dance.

I had 'anything by me' checked, but I couldn't see it. I made extra sure that if 'anything by me' was checked, then it didn't matter if the dance was in the sketchbook or private or whatever. It should display.

Only it wasn't there.

I kept debugging. I wasn't reproducing it in automated tests. What was going on here?

The answer was: the private dance wasn't tagged as verified. :(

So how do these various heading groups interact? Are they combined with 'and' or with 'or'? It must be 'and', right? I don't want to search for "Cary Ravitz" in the choreographer field, and select "verified" dances, and get a bunch of dances that are verified and not by Cary Ravitz.

But my expectation for "by me" breaks that mold and now I feel confused and demoralized about coming up with a coherent vision for the ez filters.

Probably dumb ideas for a solution:

1) Promote 'only by me' to its own section (users will have to deal with the same confusion I felt about verified tags, and we'll also have to add a 'search your private dances' checkbox). 2) Remove 'only by me' from the UI for now

dcmorse commented 4 years ago

Option One: remove the 'Shared' section entirely

Search all dances by default (published dances and dances by me), but subject still to what the user checked in the 'Verified' section, which is by default only 'verified'. So presumably their private dances haven't been verified and thus won't show up. Other people's sketchbooks would not be searchable.

Pros: at least this focuses the user's attention on only one section that could be maliciously hiding their dances.

Cons: there is no way to opt in to search others' sketchbooks. Sketchbooks become a more fringe idea.

Option Two: a dumb 'Shared' section

It has only 'shared', 'sketchbook', and 'off' entries. 'shared' is the only one checked by default. To actually see your brainfart dances, you'd have to do two things: check boxes in this section, and /somehow remember/ to check the 'not verified' checkbox in verified. I'm pessimistic.

Cons It's a setting that often will need to be thought about then overlooked. On the occassions where it's needed, it requires also interacting with another section - verified - to get it to work. This forces the user to think.

Option 3: search both verified and not-verified dances by default.

With this more historical approach to verification, then the smarter checkboxes at the head of this issue begin to make sense again (shared/sketchbooks/anything by me). The user is never two or more clicks away from a filter that doesn't do what the labels of the checkboxes say. However, the cost of this is that at zero clicks you see unverified dances. Hmmm.

dcmorse commented 4 years ago

Option 4: the original plan, with a warning light

the options at the root of this issue: (shared/sketchbook/anything by me), but when 'sketchbook' or 'anything by me' is checked, and 'not verified' isn't checked, a warning light comes on right in the 'Shared' section saying "only seeing verified dances". 

You won't be able to find your unverified dances until you check 'not verified'.
cranhandler commented 4 years ago

I vote for Option 4.

dcmorse commented 4 years ago

Making it so, captain!

Couple-a tweaks under consideration:

dcmorse commented 4 years ago

Closing for now. We can reopen in a new card once we've paused to gather feedback.

cranhandler commented 4 years ago

I approve these tweaks.

On Fri, Feb 7, 2020 at 6:43 PM Dave Morse notifications@github.com wrote:

Making it so, captain!

Couple-a tweaks under consideration: -anything by me is not checked by default so that people don't have to see a scary warning message on their first arrival at the page.

  • replace "omniscient" with "private". It's still only visible to admins, because regular Janes can see their private dances with anything by me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/contradb/contra/issues/620?email_source=notifications&email_token=AD3OHTMVP2ANN2Z5IW63UCDRBX54ZA5CNFSM4KQLS3A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFDETI#issuecomment-583676493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3OHTKROBIEIU7SBGBNKMTRBX54ZANCNFSM4KQLS3AQ .