contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts
https://py.contrails.org/
Apache License 2.0
59 stars 18 forks source link

Bugfix/vector subclass #123

Closed zebengberg closed 11 months ago

zebengberg commented 11 months ago

This PR fixes a few small bugs.

Fixes

Internals

Tests

@nickmasson -- FYI, I think this is independent of our API work.

zebengberg commented 11 months ago

Cool 🚀 Will this be released as 0.49.2?

[EDIT] -- disregard below, sorry! I take "independent of our API work" to mean that these changes aren't fixes for the failing 0.49.1 upgrade sitting in pycontrails-api"...

Sorry for the confusion! Originally I was thinking that the fixes here were necessary for work on the API, but I don't think they're actually needed.

You're absolutely right that pycontrails should have more unit tests, and that the API doubles as an integration test. Like you've pieced together, I discover the pycontrails issues fixed in this PR while debugging some other stuff in the API. Typically when this happens, I create a minimal unit test over here to reproduce the issue.

I won't create a new 0.49.2 release yet unless it turns out the API needs these updates.

zebengberg commented 11 months ago

some of these files may have been pre-auto-formatter.

The formatting changes are from black 23.12. A lot of the recent black minor releases have included these sorts of breaking changes.