contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts
https://py.contrails.org/
Apache License 2.0
59 stars 18 forks source link

Fix/short flight resampling #165

Closed thabbott closed 8 months ago

thabbott commented 8 months ago

Addresses https://github.com/contrailcirrus/flights-pipeline/issues/56

Changes

Updates flight resampling logic to ensure that resampled waypoints include any and all times between flight start and end times that are a multiple of the resampling frequency.

Breaking changes

Updates to flight resampling logic may add an additional waypoint to some flights after resampling, and may result in Flight.resample_and_fill returning a flight with a single waypoint rather than an empty flight.

Fixes

Flight resampling aligns with expected behavior for very short flights, which is now detailed in the Flight.resample_and_fill docstring.

Tests

Reviewer

@nickmasson