Bugfix for #184 is implemented as discussed in the issue, and thermo.c_pm is now tested in tests/units/test_thermo_sac.
The bugfix has enough of a downstream effect on SAC calculations to cause failures for a small number of tests of pinned CoCiP output values, so I've updated the pinned values.
Breaking changes
Bugfix will decrease computed values of moist heat capacity with non-zero specific humidity.
Fixes
Fix moist heat capacity bug in thermo.c_pm.
Internals
Update pinned CoCiP output values after moist heat capacity bugfix.
Closes #184
Changes
Bugfix for #184 is implemented as discussed in the issue, and
thermo.c_pmis now tested intests/units/test_thermo_sac.The bugfix has enough of a downstream effect on SAC calculations to cause failures for a small number of tests of pinned CoCiP output values, so I've updated the pinned values.
Breaking changes
Fixes
thermo.c_pm.Internals
Tests
make test)Reviewer