contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts
https://py.contrails.org/
Apache License 2.0
59 stars 18 forks source link

APCEMM interface #197

Closed thabbott closed 5 months ago

thabbott commented 6 months ago

I'm leaving this PR as a draft for now because I'm anticipating that I'll make changes as I get this interface ready for the pycontrails workshop. Some likely changes include

But, I think the interface is at a point where it's ready for review. @mlshapiro: go to town. @nickmasson: would you mind looking specifically at the run function in interface.py and the run_apcemm method in adapter.py to make sure I'm not doing anything dumb setting up child processes to run APCEMM?

@sdeastham: feel free to chime in here as much or a little as you'd like!

Changes

Features

Internals

Tests

Reviewer

@mlshapiro @nickmasson

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

thabbott commented 5 months ago

I've finished making changes--@mlshapiro, you're free to test drive again!

I will note that the output in the notebook looks different than what you saw initially. I think this is because I found and fixed an issue in the azimuth initialization in DryAdvection, and the contrail is being spread less by normal shear as a result.