contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts
https://py.contrails.org/
Apache License 2.0
59 stars 18 forks source link

Landsat and Sentinel-2 datalibs #200

Closed thabbott closed 5 months ago

thabbott commented 6 months ago

Changes

Features

Internals

Tests

Reviewer

@mlshapiro

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

thabbott commented 5 months ago

I think your re-organization makes sense! Moving the generic search and query functions to _leo_utils should help make it clear to users that they (in almost all cases) want to use e.g. landsat.search and not _leo_utils.search.

I added some quotes about get calls taking a while to notebooks in https://github.com/contrailcirrus/pycontrails/pull/200/commits/8dcd483bf3c3254c28aba6a21cc3b44d0ce6d22b. (They've been pretty quick for me, but that's been running on a VM with fast transfer speeds from google cloud buckets. I suspect you were running locally?)