Exclude netcdf4 1.7.0 in dependencies - Githubissues

contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts

https://py.contrails.org/

Apache License 2.0

57 stars 16 forks source link

Exclude netcdf4 1.7.0 in dependencies #204

Closed thabbott closed 4 months ago

thabbott commented 4 months ago

Unit tests have been failing non-deterministically since the release of netCDF4 version 1.7.0.

To reproduce failures, run

while pytest tests/unit/test_ecmwf.py; do; done

with netCDF4 1.7.0 installed.

For failures in CI, see e.g. https://github.com/contrailcirrus/pycontrails/actions/runs/9519726634.

Downgrading to netCDF4 1.6.5 appears to resolve this problem.

Changes

Fixes

Exclude netCDF version 1.7.0, which causes non-deterministic failures in unit tests primarily due to segmentation faults.

Tests

[x] QC test passes locally (make test)
[x] CI tests pass

Reviewer

@mlshapiro